Update ubi base image #345
Conversation
Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Build the manager binary | |||
| FROM registry.access.redhat.com/ubi8/go-toolset:1.19.10-16 as builder | |||
| FROM registry.redhat.io/ubi8/go-toolset:1.19 as builder | |||
There was a problem hiding this comment.
Should registry.access.redhat.com be kept?
There was a problem hiding this comment.
The nice thing about keeping it registry.access.redhat.com is that we can pull it without signing in to Red Hat. But if we change it to the registry.redhat.io, then all the CI and anyone testing from their laptops would require red hat login credentials, I believe.
podman pull registry.redhat.io/ubi8/go-toolset:1.19
Trying to pull registry.redhat.io/ubi8/go-toolset:1.19...
Error: initializing source docker://registry.redhat.io/ubi8/go-toolset:1.19: unable to retrieve auth token: invalid username/password: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication
versus:
podman pull registry.access.redhat.com/ubi8/go-toolset:1.19
Trying to pull registry.access.redhat.com/ubi8/go-toolset:1.19...
Getting image source signatures
Checking if image destination supports signatures
Copying blob sha256:c1903f1702cbd9a2990535c6252cfb9515ccd5cab8f977e301e91ea4bbdfd0be
...
There was a problem hiding this comment.
Thanks @jbusche, I agree with you.
Note these are pointing to the exact same image. It's only the access that changes.
There was a problem hiding this comment.
Actually CI is failing for that exact reason.
There was a problem hiding this comment.
Thanks guys, I wan't aware. I'll update now
dimakis
force-pushed
the
update-ubi-base-image
branch
from
ff651dd to
8c187c8
Compare
dimakis
force-pushed
the
update-ubi-base-image
branch
from
8c187c8 to
d048c82
Compare
|
This is a huge improvement over the rc.2 image, but it's not clear to me how much of it is due to the new go-toolset:1.19 image versus just doing a new rebuild to pickup the latest OS fixes from the ubi-minimal:8.8, but as you can see it's much better: quay.io/project-codeflare/codeflare-operator:v1.0.0-rc.2 versus the one I just build from the Dimitri branch (once I fixed the io to com) |
|
I also stood it up on my server, and the new image is properly processing appwrappers: and |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
What changes have been made
updates base image as per this conversation
Verification steps
Checks